Use a finer exception when local_files_only=True and a file is missing in cache #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
reviewed
Aug 10, 2022
There was a problem hiding this comment.
Thanks for adding this, left some nits here and there as the error is raised in two situations:
local_files_only=Trueand the file is not in the cachelocal_files_only=False, there is a connection error (timeout/connection error) or offline mode is enabled (which is the same as the first bullet point) and the file is not in the cache
The doc only mentioned the first part.
sgugger
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #979. See discussion is issue about
LocalEntryNotFoundinheritance.