-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable coverage in CI #992
Conversation
The documentation is not available anymore as the PR was closed or merged. |
Update: code coverage is now working as expected on the Coverage is measured at ~80% (see codecov report). At the moment, most branch/compare sections of codecov are broken. I suspect this is because it tries to compare against main branch that has cov reports only on the I also made a refactoring of python-tests.yml workflow to leverage even more the github matrix and avoid duplication of steps. I think it would be easier to review it directly from the file instead of looking at the diff. In theory I kept exactly the same steps for each build (+add the cov reports). @LysandreJik @osanseviero @adrinjalali could you please have a look at it ? Thanks in advance 🙂 🙏 EDIT: I also enabled comments from codecov in PRs. Let's see and if it's too annoying we will remove them. |
The workaround I used to get proper coverage is to run tests from the Then I updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, the paths-ignore
could also be removed, we've moved those folders out of this repo.
Thankss a bunch for this. Let's see what it does then.
I couldn't figure out how to give you those permissions, but I deleted the content there. |
Related to #977.
Draft mode since it's not close to be reviewed :D