Update push_to_hub.py #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to gym has altered gym.envs.registry to a dictionary. The change alters behavior on the initial huggingface.co Unit1 tutorial if not using Google CoLab.
Reproduce using WSL windows 10 ubuntu
Distributor ID: Ubuntu
Description: Ubuntu 22.04.1 LTS
Release: 22.04
To Reproduce:
Follow tutorial on Unit1 as defined...
>>> package_to_hub(model=model, model_name=model_name,model_architecture=model_architecture,env_id=env_id,eval_env=eval_env,repo_id=repo_id,commit_message=commit_message)
ℹ This function will save, evaluate, generate a video of your agent,
create a model card and push everything to the hub. It might take up to 1min.
This is a work in progress: if you encounter a bug, please open an issue.
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/theiss/.local/lib/python3.10/site-packages/huggingface_sb3/push_to_hub.py", line 364, in package_to_hub
is_deterministic = not is_atari(env_id)
File "/home/theiss/.local/lib/python3.10/site-packages/huggingface_sb3/push_to_hub.py", line 104, in is_atari
entry_point = gym.envs.registry[env_id].entry_point
AttributeError: 'dict' object has no attribute 'env_specs'
Similar to issue mentioned:
File "/home/anavani/anaconda3/envs/rad/lib/python3.7/site-packages/dmc2gym/__init__.py", line 28, in make
if not env_id in gym.envs.registry.env_specs:
AttributeError: 'dict' object has no attribute 'env_specs'
openai/gym#3097
|
Ran into this issue when using the unit1 tutorial - downgraded gym to v 0.23.1 for the time being to work around it. |
|
Hey there 👋 closing the PR since we're updating the package to v2.3 with Gymnasium support 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to gym has altered gym.envs.registry to a dictionary. The change alters behavior on the initial huggingface.co Unit1 tutorial if not using Google CoLab.
Reproduce using WSL windows 10 ubuntu
Distributor ID: Ubuntu
Description: Ubuntu 22.04.1 LTS
Release: 22.04
To Reproduce:
Follow tutorial on Unit1 as defined...
Similar to issue mentioned:
File "/home/anavani/anaconda3/envs/rad/lib/python3.7/site-packages/dmc2gym/init.py", line 28, in make
if not env_id in gym.envs.registry.env_specs:
AttributeError: 'dict' object has no attribute 'env_specs'
openai/gym#3097