Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix raise import error in desktop #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix raise import error in desktop #72

wants to merge 1 commit into from

Conversation

IncubatorShokuhou
Copy link

@IncubatorShokuhou IncubatorShokuhou commented Sep 22, 2021 •
edited
Loading

Currently, knockknock will only print the error message instead of raise an error when win10toast is not install on win10 desktop. This PR fixes it so that user will correctly see

ImportError: Error: to use Windows Desktop Notifications, you need to install `win10toast` first. Please run `pip install win10toast==0.9`.

instead of

UnboundLocalError: local variable 'ToastNotifier' referenced before assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@IncubatorShokuhou