Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Venv isn't needed in docker #454

Open
MichaelrMentele opened this issue Sep 25, 2024 · 1 comment
Open

Venv isn't needed in docker #454

MichaelrMentele opened this issue Sep 25, 2024 · 1 comment
Assignees

Comments

@MichaelrMentele
Copy link

I noticed in your docker files you are using a virtual environment. Docker is already a virtual environment at the system level. Is there a reason for using a python virtual environment as well? Typically, this is redundant/unnecessary and you'd only use venv or similar on your local machine.

If there isn't a good reason we could go ahead and delete these dependencies from the docker images.

@apockill
Copy link

apockill commented Dec 6, 2024

Not directly related, but if you're interested in docker, could you give #519 a try? I need some user testing outside of my own specific robot 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants