Skip to content

Commit

Permalink
removed temperature from default vllm params as it should be passed v…
Browse files Browse the repository at this point in the history
…ia the generationparams instead
  • Loading branch information
clefourrier committed Dec 17, 2024
1 parent e8b9057 commit dece2f9
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/lighteval/models/vllm/vllm_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ class VLLMModelConfig:
generation_parameters: GenerationParameters = None # sampling parameters to use for generation

subfolder: Optional[str] = None
temperature: float = 0.6 # will be used for multi sampling tasks, for tasks requiring no sampling, this will be ignored and set to 0.

def __post_init__(self):
if not self.generation_parameters:
Expand Down Expand Up @@ -309,7 +308,6 @@ def _generate(
"""Contains the actual logic of the generation."""
sampling_params = self.sampling_params.clone() or SamplingParams()
if generate:
sampling_params.temperature = float(self._config.temperature) if num_samples > 1 else 0.0
sampling_params.n = num_samples
sampling_params.max_tokens = max_new_tokens
sampling_params.stop = stop_tokens
Expand Down

0 comments on commit dece2f9

Please sign in to comment.