Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding documentation #282

Closed
wants to merge 29 commits into from
Closed

adding documentation #282

wants to merge 29 commits into from

Conversation

NathanHB
Copy link
Member

No description provided.

@NathanHB NathanHB marked this pull request as draft August 28, 2024 12:07
Copy link
Collaborator

@guipenedo guipenedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks pretty good. Some notes:

  • the saving results section is quite outdated and this is probably one of the most important sections (see my suggestions)
  • missing an explanation on what each metric does, how things are normalized etc
  • arguments for the commands, such as pretrained=... and task list (and task groups) should likely also be better explained, as this is the entrypoint to run evals

Comment on lines 11 to 12
Note that it is still very much early so don't expect 100% stability ^^' In
case of problems or questions, feel free to open an issue!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still the same text as from the original release I believe. Maybe at this point it's ok to rephrase a bit into something less "it's very alpha" and more along the lines of "Even though lighteval has successfully been used in a variety of different research projects both internally and externally, keep in mind that parts of it are liable to change, and things may break. In case of problems or questions, feel free to open an issue!"

docs/source/quicktour.md Show resolved Hide resolved
docs/source/quicktour.md Show resolved Hide resolved
docs/source/installation.md Show resolved Hide resolved
docs/source/saving_results.md Outdated Show resolved Hide resolved
docs/source/adding_new_metric.md Outdated Show resolved Hide resolved
docs/source/adding_new_metric.md Outdated Show resolved Hide resolved
docs/source/adding_new_metric.md Outdated Show resolved Hide resolved
docs/source/metric_list.md Outdated Show resolved Hide resolved
--output_dir="./evals/"
```

Here, `--tasks` refers to either a comma-separated list of supported tasks from
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also mention task groups #308

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the PR is merged yeah I will add it

NathanHB and others added 15 commits September 17, 2024 17:21
Co-authored-by: Guilherme Penedo <nostrumg@gmail.com>
Co-authored-by: Guilherme Penedo <nostrumg@gmail.com>
Co-authored-by: Guilherme Penedo <nostrumg@gmail.com>
Co-authored-by: Guilherme Penedo <nostrumg@gmail.com>
Co-authored-by: Guilherme Penedo <nostrumg@gmail.com>
Co-authored-by: Guilherme Penedo <nostrumg@gmail.com>
Co-authored-by: Guilherme Penedo <nostrumg@gmail.com>
Co-authored-by: Guilherme Penedo <nostrumg@gmail.com>
Co-authored-by: Guilherme Penedo <nostrumg@gmail.com>
Co-authored-by: Guilherme Penedo <nostrumg@gmail.com>
Co-authored-by: Guilherme Penedo <nostrumg@gmail.com>
Co-authored-by: Guilherme Penedo <nostrumg@gmail.com>
@clefourrier
Copy link
Member

Do you want to keep this one open since we now have the wiki?

@NathanHB
Copy link
Member Author

nope we can close

@NathanHB NathanHB closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants