Skip to content

Avoid nested InheritFromOtherOptimizer #267

@NouamaneTazi

Description

@NouamaneTazi

We shouldn't pass a InheritFromOtherOptimizer to another InheritFromOtherOptimizer InheritFromOtherOptimizer(optimizer=InheritFromOtherOptimizer(), ...)

But when adding an assert and launch a training we do hit it (so we should fix init_optimizer_and_grad_accumulator)
Image

Shouldn't be a big issue, but we can avoid the additional nesting

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions