Support Expert Parallelism #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrsrke
requested changes
Feb 16, 2024
| @@ -20,6 +20,7 @@ class ParallelismArgs: | |||
| dp: Number of DP replicas | |||
| pp: Number of PP stages | |||
| tp: Number of TP replicas | |||
| expert_parallel_size: Number of expert parallel replicas (used only for MoEs) | |||
There was a problem hiding this comment.
Isn't expert_parallel_size should be the number of experts per tp rank?
There was a problem hiding this comment.
Not quite, expert parallelism is orthogonal to TP. for example you can have 1 expert sharded along 2 tp ranks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.