Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes prediction work on GPUs #149

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Makes prediction work on GPUs #149

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f9c84c
Makes this work on GPUs
dirkgr Apr 9, 2019
a305b6d
Further fixes for GPU prediction
dirkgr Apr 9, 2019
de5f93b
Makes the cupy dependency optional
dirkgr Apr 9, 2019
457c10d
One more fix. This should have been part of the original set of fixes.
dirkgr Apr 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 25 additions & 22 deletions neuralcoref/neuralcoref.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@ import array
from libc.stdint cimport uint16_t, uint32_t, uint64_t, uintptr_t, int32_t

import numpy
try:
import cupy
to_numpy = cupy.asnumpy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can avoid this dependency check by relying on Thinc for that.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you feel about this?

def to_numpy(a):
    if thinc.neural.util.is_cupy_array(a):
        import cupy
        return cupy.asnumpy(a)
    else:
        return a

That way there isn't a conditional import, but we still have to import cupy. I'm not that familiar with thinc, but the thinc source does not use cupy.asnumpy() anywhere, so there probably isn't a good wrapper.

except ModuleNotFoundError:
to_numpy = lambda x: x

from thinc.neural.util import get_array_module
from cymem.cymem cimport Pool
from srsly import json_dumps, read_json

Expand Down Expand Up @@ -574,9 +581,10 @@ cdef class NeuralCoref(object):
for key, words in conv_dict.items():
norm_k = simple_normalize(key)
norm_w = list(simple_normalize(w) for w in words)
embed_vector = numpy.zeros(self.static_vectors.shape[1], dtype='float32')
for hash_w in norm_w:
embed_vector += self.tuned_vectors[hash_w] if hash_w in self.tuned_vectors else self.get_static(hash_w)
embed_vector = sum(
self.tuned_vectors[hash_w] if hash_w in self.tuned_vectors else self.get_static(hash_w)
for hash_w in norm_w
)
self.conv_dict.add(key=norm_k, vector=embed_vector/max(len(norm_w), 1))

def __call__(self, doc, greedyness=None, max_dist=None, max_dist_match=None,
Expand Down Expand Up @@ -639,7 +647,7 @@ cdef class NeuralCoref(object):
Doc doc
uint64_t i, ant_idx, men_idx, b_idx, n_mentions, n_pairs
uint64_t [::1] p_ant, p_men, best_ant
float [::1] embed, feats, doc_embed, mention_embed, best_score
float [::1] embed, feats, mention_embed, best_score
float [:, ::1] s_inp, p_inp
float [:, ::1] s_score, p_score
Pool mem
Expand All @@ -649,6 +657,8 @@ cdef class NeuralCoref(object):
# clock_gettime(CLOCK_REALTIME, &ts)
# timing0 = ts.tv_sec + (ts.tv_nsec / 1000000000.)

xp = get_array_module(self.static_vectors.data)

annotations = []
# if debug: print("Extract mentions")
for doc in docs:
Expand Down Expand Up @@ -717,8 +727,7 @@ cdef class NeuralCoref(object):
# if debug: print("Build single features and pair features arrays")
# ''' Build single features and pair features arrays '''
doc_c = doc.c
doc_embedding = numpy.zeros(SIZE_EMBEDDING, dtype='float32') # self.embeds.get_average_embedding(doc.c, 0, doc.length + 1, self.hashes.puncts)
doc_embed = doc_embedding
doc_embedding = xp.zeros(SIZE_EMBEDDING, dtype='float32') # self.embeds.get_average_embedding(doc.c, 0, doc.length + 1, self.hashes.puncts)
for i in range(n_mentions):
s_inp_arr[i, :SGNL_FEATS_0] = self.get_mention_embeddings(mentions[i], doc_embedding) # Set embeddings
s_inp_arr[i, SGNL_FEATS_0 + c[i].mention_type] = 1 # 01_MentionType
Expand Down Expand Up @@ -760,11 +769,11 @@ cdef class NeuralCoref(object):
best_ant_ar = numpy.empty((n_mentions), dtype=numpy.uint64)
best_score = best_score_ar
best_ant = best_ant_ar
s_score = self.model[0](s_inp_arr)
s_score = to_numpy(self.model[0](xp.asarray(s_inp_arr)))
for i in range(n_mentions):
best_score[i] = s_score[i, 0] - 50 * (greedyness - 0.5)
best_ant[i] = i
p_score = self.model[1](p_inp_arr)
p_score = to_numpy(self.model[1](xp.asarray(p_inp_arr)))
for i in range(n_pairs):
ant_idx = p_ant[i]
men_idx = p_men[i]
Expand Down Expand Up @@ -814,8 +823,8 @@ cdef class NeuralCoref(object):
scores_dict[mention] = {mention: score}
# pair scores
for i in range(n_pairs):
antecedent = mentions[p_ant[i]]
mention = mentions[p_men[i]]
antecedent = mentions[int(p_ant[i])]
mention = mentions[int(p_men[i])]
score = p_score[i, 0]
if mention in scores_dict:
scores_dict[mention][antecedent] = score
Expand Down Expand Up @@ -892,23 +901,17 @@ cdef class NeuralCoref(object):
return self.get_word_embedding(sent.doc[i])

def get_average_embedding(self, Span span):
cdef int i
cdef int n = 0
embed_arr = numpy.zeros(self.static_vectors.shape[1], dtype='float32')
for token in span:
if token.lower not in PUNCTS:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove these?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all about removing the call to numpy.zeros(). Once I had replaced it with sum(), the code collapsed into just those two lines. Other than the location of the output vector, it should perform exactly the same way.

n += 1
embed_vector = self.get_word_embedding(token, tuned=False)
embed_arr = embed_arr + embed_vector
embed_arr = numpy.divide(embed_arr, float(max(n, 1)))
return embed_arr
tokens = [token for token in span if token.lower not in PUNCTS]
return sum(self.get_word_embedding(token, tuned=False) for token in tokens) / float(max(len(tokens), 1))

def get_mention_embeddings(self, Span span, doc_embedding):
''' Create a mention embedding with span (averaged) and word (single) embeddings '''
doc = span.doc
sent = span.sent
embeddings = numpy.zeros((EMBED_13, ), dtype='float32')
embeddings[ :EMBED_01] = self.get_average_embedding(span)
span_embeddings = self.get_average_embedding(span)
xp = get_array_module(span_embeddings)
embeddings = xp.zeros((EMBED_13, ), dtype='float32')
embeddings[ :EMBED_01] = span_embeddings
embeddings[EMBED_01:EMBED_02] = self.get_average_embedding(doc[max(span.start-5, sent.start):span.start])
embeddings[EMBED_02:EMBED_03] = self.get_average_embedding(doc[span.end:min(span.end + 5, sent.end)])
embeddings[EMBED_03:EMBED_04] = self.get_average_embedding(sent)
Expand Down