Adds support to new SDXL dreambooth LoRA training script features + QOL features #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
LGTM! nice revamp on the notebook and new template for upload to hub! |
pcuenca
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Great work, I think the additions are very useful!
Not sure how to review the notebook diff effectively, so I'll just write down what I saw:
- The model card metadata appears to be wrong, see https://huggingface.co/LinoyTsaban/corgy_dog_LoRA/blob/main/README.md. Critically,
base_modelis preceded by an additional yaml separator, so it doesn't work. Also maybe quote or bold the trigger phrase in the trigger words section, as it now flows with the text without separation. - There are some warnings about xFormers not working properly.
- nit typos in the
Launch trainingsection:soley->solely,in that case->In that case
- added a call to create_repo and removed --push_to_hub tag - removed xformers install as I think it will likely not work for most users
pcuenca
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns the notebook with the huggingface/diffusers#5508 + adds some QOL features to the notebook -while keeping it free tier - including:
loading data from a local folder
hub login with notebook_login()
auto-captioning option with blip
use of custom captions for training
updated documentation aligned with and highlighting the updated features of the script