Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Llama/Llama2 support in Question-Answering #745

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

kplau1128
Copy link
Contributor

Added Llama/Llama2 support in Question-Answering

@kplau1128 kplau1128 requested a review from regisss as a code owner February 29, 2024 03:37
@kplau1128
Copy link
Contributor Author

kplau1128 commented Feb 29, 2024

Fixed issue reported GS-23: missing LlamaForQuestionAnswering class issue reported is fixed by applying huggingface/transformers 28777.

Fixed run_qa.py script to support Llama tokenizer.

@regisss
Copy link
Collaborator

regisss commented Feb 29, 2024

LlamaForQuestionAnswering was added in Transformers v4.38, which will be supported by Optimum Habana in a few weeks. Let's wait for that before continuing this PR.

@kplau1128
Copy link
Contributor Author

Verified with updated transformer v4.38.2 #788, work fine.

Copy link
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the main branch of your fork and rebase this PR on it please?

examples/question-answering/run_qa.py Outdated Show resolved Hide resolved
@kplau1128
Copy link
Contributor Author

rebased

@regisss regisss added the run-test Run CI for PRs from external contributors label Mar 18, 2024
Copy link
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I pushed two additional commits to refine a bit the README and run make style.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@regisss regisss merged commit 7d58f00 into huggingface:main Mar 18, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-test Run CI for PRs from external contributors synapse 1.15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants