Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add revision to push_to_hub #292

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Add revision to push_to_hub #292

merged 6 commits into from
Nov 6, 2023

Conversation

philschmid
Copy link
Member

@philschmid philschmid commented Nov 3, 2023

This PR adds the revision key to the push_to_hub method to push models, to specific revision, this is helpful ,e.g. to version compiled checkpoints, e.g. 2.15.0 revision.

Also removes/fixes fairscale change huggingface/transformers#25702

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@dacorvo
Copy link
Collaborator

dacorvo commented Nov 6, 2023

Thanks for this pull-request.
Regarding the addition of revision, I think it was omitted because the original method in optimum does not have it.
For consistency, it would be nice to add it also here:

.

@philschmid
Copy link
Member Author

@dacorvo added it for the decoder as well.

@philschmid philschmid merged commit 8abbcbd into main Nov 6, 2023
7 of 8 checks passed
@philschmid philschmid deleted the add-revision branch November 6, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants