Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples based on ViT #169

Closed
dacorvo opened this issue Apr 12, 2024 · 18 comments
Closed

Add examples based on ViT #169

dacorvo opened this issue Apr 12, 2024 · 18 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed Stale

Comments

@dacorvo
Copy link
Collaborator

dacorvo commented Apr 12, 2024

Vision Transformers should be supported out-of-the-box by quanto.

The goal of this issue is to add some examples under examples/vision.

At the very minimum, there should be a classification example, using a relatively small dataset so that people can rerun it locally without downloading gigabytes of images (imagenette maybe ?).

An image detection example would also be nice if possible, but maybe it requires too much code.

@dacorvo dacorvo added help wanted Extra attention is needed good first issue Good for newcomers labels Apr 12, 2024
@EduardoPach
Copy link

EduardoPach commented Apr 29, 2024

@dacorvo I can work on this one. I've been contributing to the transformers library recently, but I also want to get into the quanto library as it seems pretty fun!

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 30, 2024
Copy link

github-actions bot commented Jun 4, 2024

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 4, 2024
@dacorvo dacorvo reopened this Jun 4, 2024
@github-actions github-actions bot removed the Stale label Jun 5, 2024
Copy link

github-actions bot commented Jul 5, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jul 5, 2024
@dacorvo dacorvo removed the Stale label Jul 8, 2024
@mattiadg
Copy link
Contributor

@dacorvo I would like to work on this

@dacorvo
Copy link
Collaborator Author

dacorvo commented Jul 15, 2024

@mattiadg sure: feel free to select a model and create an example.

@mattiadg
Copy link
Contributor

Oh but I see now there are already 3 examples under vision. Maybe we want to add something different, like Whisper for speech recognition?

@dacorvo
Copy link
Collaborator Author

dacorvo commented Jul 16, 2024

@mattiadg yes a whisper example would be awesome

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 16, 2024
Copy link

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2024
@dacorvo dacorvo reopened this Aug 26, 2024
@github-actions github-actions bot removed the Stale label Aug 27, 2024
@shovan777
Copy link
Contributor

@dacorvo I am working on adding a ViT example using the oxford Pets dataset. Is that a good classification example?

@dacorvo
Copy link
Collaborator Author

dacorvo commented Sep 2, 2024

Nice ! Looking forward to see your example. When submitting your pull-request, please do not forget to use conventional commits to make it easier to review.

@shovan777
Copy link
Contributor

Nice ! Looking forward to see your example. When submitting your pull-request, please do not forget to use conventional commits to make it easier to review.

I made a PR.
But I couldn't perform model requantize as I faced a problem with quantization_map function.
Screenshot 2024-09-12 at 10 40 48
It seems the QLayerNorm doesn't have a quantization weight type. Is this a issue with QLayerNorm?

@dacorvo
Copy link
Collaborator Author

dacorvo commented Sep 12, 2024

It seems the QLayerNorm doesn't have a quantization weight type. Is this a issue with QLayerNorm?

Yes, line 168 should be modified to support weight_qtype == None, as the line below. If you don't mind, you could add a fix commit to your pull-request.

@shovan777
Copy link
Contributor

Yes, I can do that. But do you think I should create a new PR for this or should I commit in the same PR?

@dacorvo
Copy link
Collaborator Author

dacorvo commented Sep 12, 2024

Do it in the same pull-request, but in a separate commit. They are not squashed when merging so it will appear as a stand-alone change.

@shovan777
Copy link
Contributor

Do it in the same pull-request, but in a separate commit. They are not squashed when merging so it will appear as a stand-alone change.

I have made the change and committed. Is test case necessary for the change?

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed Stale
Projects
None yet
Development

No branches or pull requests

4 participants