Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): add image classification example using quantized vit … #308

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

shovan777
Copy link
Contributor

@shovan777 shovan777 commented Sep 12, 2024

What does this PR do?

This adds an image classification example using a quantized ViT model as per #169.

Before submitting

  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the github? Please add a link
    to it if that's the case.
  • Did you run all tests locally and make sure they pass.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@shovan777 shovan777 force-pushed the example_image_classification_vit branch 2 times, most recently from a7e2fbf to caeee73 Compare September 13, 2024 07:26
Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this pull-request. Can you remove the debug comments, and apply styling (make style) to make the CI green ?

@dacorvo
Copy link
Collaborator

dacorvo commented Sep 13, 2024

The CPU tests are failing because of the release of pytorch 2.4.1 last week (I have a guard preventing to use torch._int_mm for versions up to 2.4.0, but it seems it is still inaccurate in 2.4.1).

@shovan777
Copy link
Contributor Author

@dacorvo I have made the changes you requested.

@dacorvo dacorvo force-pushed the example_image_classification_vit branch from bd0332f to 10e9e0b Compare September 17, 2024 07:56
Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this pull-request !

@dacorvo dacorvo merged commit ec1f85e into huggingface:main Sep 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants