Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] enable testing for xpu #344

Closed
wants to merge 3 commits into from
Closed

Conversation

faaany
Copy link
Contributor

@faaany faaany commented Nov 1, 2024

What does this PR do?

below is an example:

======================================================== short test summary info =========================================================
PASSED test/tensor/activations/test_activations_compile.py::test_compile_qtensor_to[cpu]
PASSED test/tensor/activations/test_activations_compile.py::test_compile_qtensor_to[xpu]
==================================================== 2 passed, 12 deselected in 2.13s ====================================================

Before submitting

  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you run all tests locally and make sure they pass.
  • Did you write any new necessary tests?

@faaany
Copy link
Contributor Author

faaany commented Nov 6, 2024

@dacorvo ok,commit message updated

@dacorvo
Copy link
Collaborator

dacorvo commented Nov 10, 2024

@faaany thank you for your pull-request. You are correct: the tests are failing because the fix for #319 did not make it to pytorch 2.5.1. I just got the information that it will be fixed only in 2.6.0, so in order to have the tests pass, you need to modify the version check here to require >= 2.6.0:

version.parse(torch.__version__).release > version.parse("2.5.0").release

@faaany
Copy link
Contributor Author

faaany commented Nov 11, 2024

@dacorvo thanks for the hint! pytorch version updated! could you help retrigger the CI?

Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faaany thank you for this pull-request. Almost there: you just need to do a little change in the version comparison and edit the commit message so that it has more than two words. Maybe something like: "update int_mm minimal pytorch version"

optimum/quanto/library/qbytes_mm.py Outdated Show resolved Hide resolved
@faaany
Copy link
Contributor Author

faaany commented Nov 12, 2024

@dacorvo thanks so much! updated.

Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still an issue with the second commit message. I am approving anyway but will merge the changes in #349 .

@dacorvo dacorvo closed this Nov 12, 2024
@faaany
Copy link
Contributor Author

faaany commented Nov 13, 2024

There is still an issue with the second commit message. I am approving anyway but will merge the changes in #349 .

thanks for the rebase and merge! Will pay attention to the commit message next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants