-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] enable testing for xpu #344
Conversation
@dacorvo ok,commit message updated |
@faaany thank you for your pull-request. You are correct: the tests are failing because the fix for #319 did not make it to pytorch 2.5.1. I just got the information that it will be fixed only in 2.6.0, so in order to have the tests pass, you need to modify the version check here to require
|
@dacorvo thanks for the hint! pytorch version updated! could you help retrigger the CI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@faaany thank you for this pull-request. Almost there: you just need to do a little change in the version comparison and edit the commit message so that it has more than two words. Maybe something like: "update int_mm minimal pytorch version"
@dacorvo thanks so much! updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still an issue with the second commit message. I am approving anyway but will merge the changes in #349 .
thanks for the rebase and merge! Will pay attention to the commit message next time. |
What does this PR do?
below is an example:
Before submitting
Pull Request section?
to it if that's the case.