Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc workflows #1093

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Update doc workflows #1093

merged 2 commits into from
Jun 9, 2023

Conversation

regisss
Copy link
Contributor

@regisss regisss commented Jun 8, 2023

What does this PR do?

Following huggingface/doc-builder#379.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@regisss
Copy link
Contributor Author

regisss commented Jun 8, 2023

cc @echarlaix

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix @regisss, you rock !

The doc generation test should be fixed by installing transformers from source (issue fixed in huggingface/transformers#24138)

@regisss
Copy link
Contributor Author

regisss commented Jun 9, 2023

So should I merge it now?

@echarlaix
Copy link
Collaborator

So should I merge it now?

Yes will do once the test related to the doc pass !! And also v4.30.1

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 9, 2023

The documentation is not available anymore as the PR was closed or merged.

@echarlaix echarlaix merged commit b87cbd2 into main Jun 9, 2023
@echarlaix echarlaix deleted the update_doc_workflows branch June 9, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants