Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated use_auth_token #1837

Merged
merged 7 commits into from
Jun 25, 2024
Merged

Deprecated use_auth_token #1837

merged 7 commits into from
Jun 25, 2024

Conversation

IlyasMoutawwakil
Copy link
Member

@IlyasMoutawwakil IlyasMoutawwakil commented Apr 26, 2024 •
edited
Loading

What does this PR do?

This PR deprecates the use use_auth_token in favor of token.

Fixes #1836

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@fxmarty @echarlaix @mht-sharma

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@IlyasMoutawwakil IlyasMoutawwakil self-assigned this May 29, 2024
fxmarty
fxmarty approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

optimum/configuration_utils.py Show resolved Hide resolved
optimum/exporters/tasks.py Outdated Show resolved Hide resolved
@IlyasMoutawwakil IlyasMoutawwakil merged commit 60efc2a into main Jun 25, 2024
52 of 64 checks passed
@IlyasMoutawwakil IlyasMoutawwakil deleted the deprecate-use_auth_token branch June 25, 2024 13:26
@JingyaHuang JingyaHuang mentioned this pull request Sep 16, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxmarty fxmarty fxmarty approved these changes

@echarlaix echarlaix Awaiting requested review from echarlaix

Assignees

@IlyasMoutawwakil IlyasMoutawwakil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pushing to the hub with a token
3 participants
@IlyasMoutawwakil @HuggingFaceDocBuilderDev @fxmarty