Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ORTPipelineForxxx entrypoints #1960

Merged
merged 27 commits into from
Sep 16, 2024
Merged

adding ORTPipelineForxxx entrypoints #1960

merged 27 commits into from
Sep 16, 2024

Conversation

IlyasMoutawwakil
Copy link
Member

@IlyasMoutawwakil IlyasMoutawwakil commented Jul 16, 2024

What does this PR do?

Continuing the effort in #1947
This PR adds the Task specific entrypoints.
It also standardize and make the testing suite more compact, by grouping model tests by task, which revealed some problems in the current modeling, I fixed some, like accepting torch generators for compatibility with diffusers. But we observe many errors in reproducibility of outputs and comparison with diffusers.
Another PR that updates the export/modeling (mixins) fixes these issues #2021.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@IlyasMoutawwakil IlyasMoutawwakil marked this pull request as ready for review September 4, 2024 08:11
optimum/modeling_base.py Show resolved Hide resolved
optimum/onnxruntime/__init__.py Show resolved Hide resolved
optimum/onnxruntime/modeling_diffusion.py Show resolved Hide resolved
Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks @IlyasMoutawwakil

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🔥

optimum/utils/dummy_diffusers_objects.py Outdated Show resolved Hide resolved
@echarlaix echarlaix merged commit ca36fc4 into main Sep 16, 2024
62 of 64 checks passed
@echarlaix echarlaix deleted the auto-diffusion-pipeline branch September 16, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants