Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the logic to combine subpackages' documentation #429

Merged
merged 3 commits into from
Oct 25, 2022

Conversation

regisss
Copy link
Contributor

@regisss regisss commented Oct 24, 2022

What does this PR do?

This PR changes the way the documentation of Optimum's subpackages is combined to the main doc. We currently add a prefix subpackage_ at the beginning of each file but the code is not adapted to the new documentation structure (cf. #395).

The new logic consists in creating a new repository for each subpackage. Then, the structure of the subpackages' documentations are copied inside each one of these subpackage folders.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 24, 2022

The documentation is not available anymore as the PR was closed or merged.

@regisss regisss marked this pull request as ready for review October 24, 2022 18:27
@regisss regisss requested a review from lewtun October 24, 2022 18:27
Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @regisss - LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants