Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark results to gpu doc #525

Merged
merged 14 commits into from
Nov 30, 2022
Merged

Add benchmark results to gpu doc #525

merged 14 commits into from
Nov 30, 2022

Conversation

JingyaHuang
Copy link
Collaborator

What does this PR do?

Add benchmark results to GPU usage documentation.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 29, 2022

The documentation is not available anymore as the PR was closed or merged.

@fxmarty
Copy link
Contributor

fxmarty commented Nov 29, 2022

It's really nice, thanks for adding this!

For me the figures are quite small, could we maybe put them one after the other? Or allow in JS to click and zoom (no idea if it's possible)? See:

image

Also, I'm not sure to understand the legend in the figures:

image

There are full and dotted black lines in the legend but not in the plot. Also dotted blue/orange lines, that are not in the legend. Is it expected?

Also, what does "ORT Generation" means?

@JingyaHuang
Copy link
Collaborator Author

@fxmarty ok, I will try to make the display better looking!

Nope, the legend is a combination of two groups of legends.

The first group is "Framework", which distinguishes PyTorch and ORT by color.
The second group is "Generation(mode)", which distinguishes greedy and beam search by solid and dashed lines.

@JingyaHuang
Copy link
Collaborator Author

@fxmarty Any better if I put legend this way?
Screenshot 2022-11-29 at 16 14 46

@fxmarty
Copy link
Contributor

fxmarty commented Nov 29, 2022

Yes it's much better, thanks a lot!

@JingyaHuang
Copy link
Collaborator Author

@fxmarty Graphs replaced!

Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job!

@JingyaHuang JingyaHuang merged commit 3d0a39c into main Nov 30, 2022
@JingyaHuang JingyaHuang deleted the update-gpu-doc branch November 30, 2022 13:57
@regisss
Copy link
Contributor

regisss commented Nov 30, 2022

Awesome PR @JingyaHuang!!! 🔥 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants