Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check_if_transformers_greater to manage different versions of transformers #537

Merged
merged 2 commits into from
Dec 3, 2022
Merged

Add check_if_transformers_greater to manage different versions of transformers #537

merged 2 commits into from
Dec 3, 2022

Conversation

regisss
Copy link
Contributor

@regisss regisss commented Dec 2, 2022

What does this PR do?

This PR adds a check_if_transformers_greater method in order to factorize the checks that are carried out in some source files.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@regisss regisss requested a review from fxmarty December 2, 2022 17:27
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 2, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

fxmarty
fxmarty approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@regisss regisss merged commit fb8e284 into huggingface:main Dec 3, 2022
@regisss regisss deleted the check_if_transformers_greater branch December 3, 2022 00:01
@evrial
Copy link

evrial commented Dec 3, 2022

Nice, thanks for quick update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxmarty fxmarty fxmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@regisss @HuggingFaceDocBuilderDev @evrial @fxmarty