Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of 2 functions used in ORTModel #551

Merged

Conversation

michaelbenayoun
Copy link
Member

What does this PR do?

  • Refactors validate_file_exists
  • Refactors infer_filename
  • Fixes function name in optimum/exporters/onnx/__main__.py (cc @mht-sharma)

As mentioned in #515 (cc @fxmarty)

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 6, 2022

The documentation is not available anymore as the PR was closed or merged.

Revision is the specific model version to use. It can be a branch name, a tag name, or a commit id.

Returns:
`List[Path`]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`List[Path`]
`List[Path]`

Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@michaelbenayoun michaelbenayoun merged commit f6eb417 into huggingface:main Dec 7, 2022
@michaelbenayoun michaelbenayoun deleted the infer_filename_refactor branch December 7, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants