Add test for exporters.onnx CLI #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fxmarty
requested review from
regisss,
JingyaHuang,
mht-sharma and
michaelbenayoun
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
michaelbenayoun
approved these changes
Dec 12, 2022
| @@ -0,0 +1,58 @@ | |||
| PYTORCH_EXPORT_MODELS_TINY = { | |||
There was a problem hiding this comment.
I think this could be the occasion to get rid of the PYTORCH_EXPORT_MODELS in test_onnx_export.py and use this everywhere, wdty?
There was a problem hiding this comment.
Yes, I want to do it in a next PR where we'll have nightly tests for the ONNX export with various shapes, potentially a bit larger models, while the normal (on PR and main) exporters tests would use this TINY dict!
regisss
approved these changes
Dec 12, 2022
1 task
|
Will merge and fix the failing tests in an other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title.
Simply check that the CPI does not raise errors.
Next PR: testing on various shapes, slow and fast tests.
Before submitting