Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation example #603

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Fix documentation example #603

merged 1 commit into from
Dec 20, 2022

Conversation

echarlaix
Copy link
Collaborator

No description provided.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 16, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me to have the doc use pipeline from transformers, arguably the optimum pipeline makes sense if we want to export + load the model on the fly. cc @philschmid

Just to note, the from optimum.pipelines import pipeline is used in many other places, source/onnxruntime/usage_guides/pipelines.mdx, source/onnxruntime/usage_guides/models.mdx, source/onnxruntime/usage_guides/gpu.mdx, source/bettertransformer/tutorials/convert.mdx

@echarlaix echarlaix merged commit e5e4f80 into main Dec 20, 2022
@echarlaix echarlaix deleted the fix-doc branch December 20, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants