Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nvcr.io/nvidia/tensorrt image for GPU tests #660

Merged

Conversation

fxmarty
Copy link
Contributor

@fxmarty fxmarty commented Jan 2, 2023

GPU test may need TensorRT, so let's use an image that has TensorRT pre-installed.

Still need to test that everything runs fine before merging.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 2, 2023

The documentation is not available anymore as the PR was closed or merged.

@fxmarty
Copy link
Contributor Author

fxmarty commented Jan 2, 2023

Passing on the DGX.

schedule:
- cron: 0 7 * * * # every day at 7am
pull_request:
types: [labeled]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be any label right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I added it so that the test can be triggered on a PR. I don't know if we can specify a specific tag, do you know?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@regisss Unfortunately external PRs can not access secrets from huggingface/optimum it seems, so this was not very useful: https://github.com/huggingface/optimum/actions/runs/3845671285/jobs/6550087462

Copy link
Collaborator

@JingyaHuang JingyaHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for enabling it!

@fxmarty fxmarty merged commit 0c14a50 into huggingface:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants