Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ORTModelForMaskedLM class #729

Merged
merged 5 commits into from
Jan 30, 2023
Merged

Add ORTModelForMaskedLM class #729

merged 5 commits into from
Jan 30, 2023

Conversation

JingyaHuang
Copy link
Collaborator

@JingyaHuang JingyaHuang commented Jan 30, 2023 •
edited
Loading

What does this PR do?

  • Add ORTModelForMaskedLM class.
  • Enable the fill-mask task in the pipeline.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 30, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@JingyaHuang JingyaHuang marked this pull request as ready for review January 30, 2023 15:17
@JingyaHuang
Copy link
Collaborator Author

Hi @prathikr, you can find the support for masked-lm inference with ONNX Runtime backend here.

fxmarty
fxmarty approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JingyaHuang
Copy link
Collaborator Author

As the failed tests are irrelevant(on the task speech_to_text for exporter), I will merge the PR anyway.

@JingyaHuang JingyaHuang merged commit 4cf6498 into main Jan 30, 2023
@JingyaHuang JingyaHuang deleted the add-ort-maskedlm branch January 30, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxmarty fxmarty fxmarty approved these changes

@michaelbenayoun michaelbenayoun Awaiting requested review from michaelbenayoun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JingyaHuang @HuggingFaceDocBuilderDev @fxmarty