-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update quality tooling for formatting #760
Conversation
The documentation is not available anymore as the PR was closed or merged. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this @regisss !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Is all the reformating done by ruff? It seems very nice!
Hi @regisss, sure you can remove them, they are legacy code. Thanks for improving it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great, thanks for updating the styling tools @regisss! Just left some questions to better understand the change. 💯
@michaelbenayoun No, the formatting is still done by black. Ruff is a linter that can also do the same job as isort, so it will reorder imports, remove unused variables etc... It's more a replacement for the flake8 package, which we have never used in Optimum. And it's fast! |
What does this PR do?
Following the recent changes in Transformers regarding quality tools (see huggingface/transformers#21480 and huggingface/transformers#21493), the package
flake8
is replaced byruff
. Files were formatted and corrected accordingly.Before submitting