-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BT
] Add fp16 support
#859
Merged
younesbelkada
merged 15 commits into
huggingface:main
from
younesbelkada:add-bt-fp16-support
Mar 7, 2023
Merged
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
16265ed
add fp16 support
younesbelkada 7d0ee8c
add fp16 tests and fix
younesbelkada 73d519e
propose fix
younesbelkada ad34b6b
fix
younesbelkada 1f6baa2
add logits tests
younesbelkada a50366b
make style
younesbelkada 39f339c
fix tests
younesbelkada 5338245
fix tests
younesbelkada cab4fb5
Update optimum/bettertransformer/models/decoder_models.py
younesbelkada b62a829
more tests
younesbelkada d3a5019
Merge branch 'add-bt-fp16-support' of https://github.com/younesbelkad…
younesbelkada 4b00469
revert change on codegen
younesbelkada 2b113f8
fix issues
younesbelkada f0bc7d6
Apply suggestions from code review
younesbelkada a69e1de
make style
younesbelkada File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not equivalent:
not sure if it has any influence or not though. I would just put the definition of
mask_value
in the forward directly, as in transformersThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, adapted as suggested!