Automatic framework detection in TasksManager for large models #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fxmarty
requested review from
michaelbenayoun,
regisss,
JingyaHuang and
mht-sharma
and removed request for
michaelbenayoun
|
The documentation is not available anymore as the PR was closed or merged. |
michaelbenayoun
approved these changes
Mar 15, 2023
| ) | ||
| logger.info(f"Local {framework_map[framework]} model found.") | ||
| all_files = [ | ||
| os.path.relpath(os.path.join(dirpath, file), full_model_path) |
There was a problem hiding this comment.
I am more in favor to use pathlib here but that's just my tastes:
- os.walk => path.glob
- os.path.relpath => path.relative_to
Co-authored-by: Michael Benayoun <mickbenayoun@gmail.com>
…om/fxmarty/optimum into auto-detect-framework-large-models
regisss
reviewed
Mar 15, 2023
Comment on lines
+936
to
+945
| if any(is_pt_weight_file): | ||
| framework = "pt" | ||
| elif any(is_tf_weight_file): | ||
| framework = "tf" | ||
| else: | ||
| raise FileNotFoundError( | ||
| "Cannot determine framework from given checkpoint location." | ||
| f" There should be a {Path(WEIGHTS_NAME).stem}*{Path(WEIGHTS_NAME).suffix} for PyTorch" | ||
| f" or {Path(TF2_WEIGHTS_NAME).stem}*{Path(TF2_WEIGHTS_NAME).suffix} for TensorFlow." | ||
| ) |
There was a problem hiding this comment.
I think we should log which framework has been chosen, something like:
logger.info(f"No framework specified so {framework} has been automatically chosen.")
Because here PT will have the priority over TF when there are checkpoints for both frameworks in the repo (which is fine), like BERT for instance: https://huggingface.co/bert-base-uncased/tree/main
There was a problem hiding this comment.
This is already logged in the CLI: Framework not specified. Using pt to export to ONNX. If passing export=True this is indeed not logged.
|
Merging as failing tests are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #867