Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop python 3.7 support #891

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Drop python 3.7 support #891

merged 2 commits into from
Mar 17, 2023

Conversation

fxmarty
Copy link
Contributor

@fxmarty fxmarty commented Mar 16, 2023

@fxmarty fxmarty requested a review from echarlaix March 16, 2023 16:15
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 16, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@echarlaix
Copy link
Collaborator

TensorFlow, as well as Transformers and Diffusers, support python 3.7 so I don't think we should drop it

@fxmarty
Copy link
Contributor Author

fxmarty commented Mar 17, 2023

@echarlaix yes right. Still think we should disable the CI on 3.7, as done in transformers. WDYT?

@regisss
Copy link
Contributor

regisss commented Mar 17, 2023 •
edited
Loading

@echarlaix yes right. Still think we should disable the CI on 3.7, as done in transformers. WDYT?

Sounds good to me

@fxmarty
Copy link
Contributor Author

fxmarty commented Mar 17, 2023

Merging as approved internally

@fxmarty fxmarty merged commit 980f1aa into huggingface:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echarlaix echarlaix Awaiting requested review from echarlaix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fxmarty @HuggingFaceDocBuilderDev @echarlaix @regisss