Allow to use a custom class in TasksManager & use canonical tasks names #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
fxmarty
changed the title
3 tasks
fxmarty
requested review from
michaelbenayoun,
JingyaHuang,
mht-sharma,
echarlaix and
regisss
and removed request for
michaelbenayoun and
JingyaHuang
regisss
reviewed
Apr 11, 2023
| # Set of model topologies we support associated to the tasks supported by each topology and the factory | ||
| _SUPPORTED_MODEL_TYPE = { | ||
| "audio-spectrogram-transformer": supported_tasks_mapping( | ||
| "default", | ||
| "feature-extraction", | ||
| "audio-classification", | ||
| onnx="ASTOnnxConfig", | ||
| ), | ||
| "albert": supported_tasks_mapping( |
There was a problem hiding this comment.
I would make it so that supported_tasks_mapping can accept synonyms as well. But not primordial either.
There was a problem hiding this comment.
Good call, that'd be interesting if external users are writing their own mappings. Is that something that happens frequently?
3 tasks
pcuenca
added a commit
to huggingface/exporters
that referenced
this pull request
Apr 12, 2023
According to the nomenclature used in the Hub https://huggingface.co/tasks, and following huggingface/optimum#967 which was addressed after a Slack discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some architectures do not map to an auto class in transformers (e.g. as pix2struct and VisualBert). Thus we introduce the
_CUSTOM_CLASSESin TasksManager to handle those.Moreover, when possible, we use
model_info.pipeline_taginstead ofmodel_info.transformersInfo.pipeline_tagto infer the task, as the later may be wrong. For reference: https://huggingface.slack.com/archives/C02EMARJ65P/p1681215560263539For example, now
task = TasksManager.infer_task_from_model("google/pix2struct-base")rightfully returnsimage-to-text, while it was returningtext2text-generationbefore (due to the issue explained on slack).Moreover,
model = TasksManager.get_model_from_task("image-to-text", "google/pix2struct-base")successfully loads the model asPix2StructForConditionalGeneration, although it is not registered inAutoModelForVision2Seq.Moreover, we align with the pipelines/tasks names from https://huggingface.co/datasets/huggingface/transformers-metadata/blob/main/pipeline_tags.json & https://docs.google.com/spreadsheets/d/1zvGwDwo-efnAhqepIleYLsALO70dn6dxRAF2ih8mCH8/edit#gid=0 instead of defining our own. For reference: https://huggingface.slack.com/archives/C03AHFPCWHM/p1680025770248079?thread_ts=1680020763.420539&cid=C03AHFPCWHM Backward compatibility is kept in the CLI.
Note: using
-with-pastto denote the case where past key values are used should probably not be in the task name.Backward compatibility can be tested with
RUN_SLOW=1 pytest tests/exporters/onnx/test_exporters_onnx_cli.py -k "test_legacy_tasks_backward_compatibility" -sEdit: remaining issues: