Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Comment out flaky LoHA test #1002

Merged

Conversation

BenjaminBossan
Copy link
Member

This test is flaky when running on Windows. It is probably related to PyTorch 2.1, as this test used to work. Further investigation is needed.

This test is flaky when running on Windows. It is probably related to
PyTorch 2.1, as this test used to work. Further investigation is needed.
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 6, 2023

The documentation is not available anymore as the PR was closed or merged.

@BenjaminBossan
Copy link
Member Author

BenjaminBossan commented Oct 6, 2023

@kovalexal Do you happen to have a Windows machine? Unfortunately, I don't have one to investigate this flaky loha test.

@kovalexal
Copy link
Contributor

@BenjaminBossan, Hi!

Sorry, I don't have Windows machine with gpu available nearby.

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BenjaminBossan BenjaminBossan merged commit dfd99f6 into huggingface:main Oct 9, 2023
11 checks passed
@BenjaminBossan BenjaminBossan deleted the TST-comment-out-flaky-test branch October 9, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants