Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoRA] Raise error when adapter name not found in set_scale #1034

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

younesbelkada
Copy link
Contributor

What does this PR do?

Addresses: huggingface/diffusers#5417 and as discussed offline

cc @pacman100 @BenjaminBossan

Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @younesbelkada for handling this, LGTM!

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should add some tests later.

@younesbelkada younesbelkada merged commit 56556fa into main Oct 18, 2023
11 checks passed
@younesbelkada younesbelkada deleted the fix-scale-nit branch October 18, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants