Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import issue transformers with id_tensor_storage #1116

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

younesbelkada
Copy link
Contributor

What does this PR do?

Fixes #1114

Let's just copy-past the method as the method is relatively easy and do not depend on many things

cc @BenjaminBossan @pacman100

Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @younesbelkada for the quick fix! ⚡

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 10, 2023

The documentation is not available anymore as the PR was closed or merged.

@minotru
Copy link

minotru commented Nov 10, 2023

Hi @younesbelkada, thanks for such a fast fix!

Yet, I have a general question: why don't we specify a version range for transformers in setup.py?

Because the case with id_tensor_storage is just a one of many possible errors, when dependencies versions are not specified.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, copying is better than restricting the transformers version.

@younesbelkada younesbelkada merged commit 5d84484 into main Nov 10, 2023
11 checks passed
@younesbelkada younesbelkada deleted the fix-issue-transformers branch November 10, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

peft==0.6.1 implicitly requires transformers>=4.30.0, but transformers version is not specified
5 participants