Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Add Python 3.11 to test matrix #1143

Merged

Conversation

BenjaminBossan
Copy link
Member

@BenjaminBossan BenjaminBossan commented Nov 17, 2023

Add Python 3.11 to the test matrix for unit tests.

No further changes were needed, except for one thing: Apparently, in Python 3.11, the repr of enums has changed in this case, resulting in a failing test for the warning message. By using the value of the enum, the message is the same for Python 3.11 and earlier.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 17, 2023

The documentation is not available anymore as the PR was closed or merged.

Apparently, in Python 3.11, the repr of enums has changed in this case,
resulting in a failing test for the warning message. By using the value
of the enum, the message is the same for Python 3.11 and earlier.
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @BenjaminBossan !

@BenjaminBossan BenjaminBossan merged commit 9cdaed2 into huggingface:main Nov 17, 2023
14 checks passed
@BenjaminBossan BenjaminBossan deleted the CI-tests-on-Python-3.11 branch November 17, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants