Use huggingface_hub.file_exists instead of custom helper
#1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
Oups yes of course. I thought it would be fine given the small change but still got the chance to make a mistake 😄 |
younesbelkada
approved these changes
Nov 17, 2023
younesbelkada
deleted the
remove-hub-utils-in-favor-of-official-helper
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there 👋 Small PR to use the "official"
file_existsadded tohuggingface_hubin release 0.17.0 (latest version been 0.19.4) instead of the custom helperhub_file_existsdefined in./utils/hub_utils.py. I'm trying to do some harmonization across repos and only found this piece to update in peft :)