fix add_weighted_adapter method
#1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Benjamin Bossan <BenjaminBossan@users.noreply.github.com> Co-Authored-By: jihuishan <151612440+jihuishan@users.noreply.github.com>
|
The documentation is not available anymore as the PR was closed or merged. |
younesbelkada
approved these changes
Nov 22, 2023
BenjaminBossan
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Thanks for the quick fix.
I guess, this could be considered not backwards compatible, because the same code would produce different outcomes now. I think this is fine in this case, as "linear" is not the default and as the previous behavior could be considered a "bug". But we should be sure to highlight this change in the next release notes.
Yes, noted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what does this PR do?