Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lora support for phi #1186

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Added lora support for phi #1186

merged 1 commit into from
Nov 28, 2023

Conversation

umarbutler
Copy link
Contributor

This pull request adds support for lora training microsoft/phi-1_5 by creating a new target modules mapping for models of the model_type phi.

Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @umarbutler for adding the target modules for phi-1.5B! ✨

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the change looks good. One question before merging: Do we want to update the list of supported models in the README.md as well? That should make it more discoverable.

Also, out of curiosity, does PEFT also work with FusedDense from flash_attn?

@pacman100
Copy link
Contributor

It should work with FusedDense given that it inherits from nn.Linear https://github.com/Dao-AILab/flash-attention/blob/ce3e7280f81869fda78578e91e79e8d11763a3e3/flash_attn/ops/fused_dense.py#L139. Am I missing something, @BenjaminBossan?

@BenjaminBossan
Copy link
Member

It should work with FusedDense given that it inherits from nn.Linear

I see, thanks for the pointer. I agree it looks like it should just work.

@BenjaminBossan BenjaminBossan merged commit da29ae6 into huggingface:main Nov 28, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants