-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Concept guides #1269
[docs] Concept guides #1269
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@stevhliu Let us know when this is ready for review. |
8181015
to
41f765a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this work, this must have been a lot of effort and it fills a big gap we currently have in the docs.
I made a couple of suggestions, please check if they make sense to you.
|
||
--> | ||
|
||
# Adapters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could cause confusion here. We use the name "adapter" pretty liberally throughout PEFT for all kinds of methods. Users may, e.g., pass an adapter_name
to a LoRA model. This section makes it seem that LLaMA adapter is the the only "adapter" method in PEFT.
Honestly, I'm not sure how to correctly categorize this method, there is no clear taxonomy of adapter/tuner methods :-/ But I'd rather combine this with lora.md
and call all of them adapter, as "reparametrization" is not a name I have seen used colloquially for these methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was struggling a bit with the taxonomy of it all as well, but I think your approach is better for avoiding confusion! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive work @stevhliu ! Thanks very much for all your hardwork on this!
I left one tiny suggestion, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! Thank you @stevhliu for updating the docs with overview of all the methods, usage of the features and pointers to the related resources! 🤩🚀✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the updates.
Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
This PR focuses on updating the concept guides with additional PEFT methods. Among other things, it also:
todo: