Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fsdp auto wrap policy #1302

Merged
merged 4 commits into from
Dec 27, 2023
Merged

fix fsdp auto wrap policy #1302

merged 4 commits into from
Dec 27, 2023

Conversation

pacman100
Copy link
Contributor

@pacman100 pacman100 commented Dec 26, 2023 •
edited
Loading

What does this PR do?

  1. Fixes the FSDP Auto Wrap policy for PEFT models to use the default _no_split_modules when available.

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@pacman100 pacman100 marked this pull request as ready for review December 27, 2023 05:44
younesbelkada
younesbelkada approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pacman100 pacman100 merged commit 4023da9 into main Dec 27, 2023
14 checks passed
@pacman100 pacman100 deleted the smangrul/fsdp-policy-fixes branch January 3, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesbelkada younesbelkada younesbelkada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pacman100 @HuggingFaceDocBuilderDev @younesbelkada