FEAT: add awq suppot in PEFT #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
younesbelkada
commented
Jan 26, 2024
This was referenced Feb 13, 2024
src/peft/import_utils.py
Outdated
|
|
||
| def is_auto_awq_available(): | ||
| if importlib.util.find_spec("awq") is not None: | ||
| # TODO: change it to 0.2.0 |
There was a problem hiding this comment.
This is not quite clear to me: change it when?
There was a problem hiding this comment.
Sorry I'll remove it
younesbelkada
commented
Feb 14, 2024
src/peft/import_utils.py
Outdated
|
|
||
| def is_auto_awq_available(): | ||
| if importlib.util.find_spec("awq") is not None: | ||
| # TODO: to change it to 0.2.0 after the AutoAWQ release |
There was a problem hiding this comment.
@BenjaminBossan I 'll change that to 0.2.0 before merging right after auto-awq's release
BenjaminBossan
approved these changes
Feb 14, 2024
|
AutoAWQ just made the release (thanks @casper-hansen !) - Reran the docker build and tests on my T4 machine and seems to work all well ! Merging once the CI is green ! |
Merged
BenjaminBossan
pushed a commit
to BenjaminBossan/peft
that referenced
this pull request
Mar 14, 2024
* add awq suppot in PEFT * fix * fux * Update src/peft/tuners/lora/awq.py * style & fix tests * forward contrib credits from PR14084 * forward contrib credits from autoawq PR * change name * fix * change to peft internal testing * fix * fix * add multi-GPU tests * add to dockerfile * fix todo * raise error only at the dispatch level * quality * fix test * fix dockerfile * fix * fix * update dockerfile and tests --------- Co-authored-by: s4rduk4r <s4rduk4r@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: casper-hansen/AutoAWQ#220
TODO:
Add the fix in transformers
Wait for the next awq release
Empty commit with @s4rduk4r as a co-author
add autoawq in the docker image
Figure out how to fix the current bug on the test
cc @pacman100 @casper-hansen