MNT: Check only selected directories with ruff #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR huggingface#1421, ruff was extended to check all directories. This is fine for those directories that come with PEFT. However, developers may have other local directories that they do not want to be checked. Therefore, it is better to list the directories to be checked rather than checking all.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
ping @akx |
pacman100
approved these changes
Feb 7, 2024
BenjaminBossan
added a commit
to BenjaminBossan/peft
that referenced
this pull request
Mar 14, 2024
In PR huggingface#1421, ruff was extended to check all directories. This is fine for those directories that come with PEFT. However, developers may have other local directories that they do not want to be checked. Therefore, it is better to list the directories to be checked rather than checking all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #1421, ruff was extended to check all directories. This is fine for those directories that come with PEFT. However, developers may have other local directories that they do not want to be checked. Therefore, it is better to list the directories to be checked rather than checking all.