Support modules_to_save
config option when using DeepSpeed ZeRO-3 with ZeRO init enabled.
#1450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
deeepcopy
performed inModulesToSaveWrapper
class doesn't work as expected and creates a new module with 0 parameters. As such, this results in following error when training:modules_to_save
config option are gathered across processes usingdeepspeed.zero.GatheredParameters
.without this PR, the above stated error is given and with this PR the fine-tuning happens successfully.
launch command:
Fixes: huggingface/transformers#24445 (comment)