-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add example and update deepspeed/FSDP docs #1489
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great guide, thanks a lot Sourab. I already took a look at it, not sure if it's ready for review yet :)
Apart from the comments I left, do you know some common mistakes that are easy to make when using PEFT + DS? Or some PEFT features that won't work when combined with DS (like merging weights)? Maybe those could be added to the troubleshooting section and a link added in this guide.
Let me know once this is ready for another review round. |
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
…gingface/peft into smangrul/peft-deepspeed-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for extending the PEFT docs on DeepSpeed and FSDP. Your additions are super good 🔥🔥🔥
Also very nice that you added the example scripts to along with the docs. Some comments on those:
- Is
examples/sft/__init__.py
needed? I think it can be deleted. - Pretty cool that you also included the multi-GPU and unsloth script. Right now, they are not referenced in the docs. Maybe a short README.md could be added to the folder to explain the individual scripts, just very briefly.
I also added some small comments to the docs, but those are just nits, not blockers. Do we also want to ask Steven for a review?
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
…gingface/peft into smangrul/peft-deepspeed-docs
Done. |
* add example and update deepspeed docs * fixes * fixes and update FSDP docs * fixes and addressing commentsa * fixes * resolve comments * Apply suggestions from code review Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com> * address comments * Update fsdp.md * Update docs/source/accelerate/fsdp.md Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com> * addressing comments * address comments --------- Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
What does this PR do?