Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: [Docker] Notify us when docker build pass or fail #1503

Merged
merged 4 commits into from
Feb 27, 2024
Merged

ENH: [Docker] Notify us when docker build pass or fail #1503

merged 4 commits into from
Feb 27, 2024

Conversation

younesbelkada
Copy link
Contributor

As discussed offline cc @glegendre01

@younesbelkada
Copy link
Contributor Author

We could use re-usable workflows here cc @glegendre01

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@younesbelkada younesbelkada marked this pull request as draft February 22, 2024 15:06
@younesbelkada
Copy link
Contributor Author

cc @glegendre01 @pacman100 @BenjaminBossan I tested out everything and seems to work great, this PR is ready for review!

@younesbelkada younesbelkada marked this pull request as ready for review February 27, 2024 05:27
pacman100
pacman100 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Younes for adding this to alert when the Docker build fails!

BenjaminBossan
BenjaminBossan approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

There is a lot of code duplication which could probably be avoided with a matrix build, but if it works as is, I'm fine.

@younesbelkada
Copy link
Contributor Author

Yeah I agree, we could also put it in a re-usable workflow. Will do it as a follow up PR !

@younesbelkada younesbelkada merged commit 90aa2c1 into main Feb 27, 2024
14 checks passed
@younesbelkada younesbelkada deleted the younesbelkada-patch-1 branch February 27, 2024 09:12
@younesbelkada younesbelkada mentioned this pull request Feb 27, 2024
Merged
@sayakpaul sayakpaul mentioned this pull request Feb 27, 2024
Merged
BenjaminBossan pushed a commit to BenjaminBossan/peft that referenced this pull request Mar 14, 2024
@younesbelkada @BenjaminBossan
ENH: [Docker] Notify us when docker build pass or fail (huggingface…
e137d30 
…#1503)

* Update build_docker_images.yml

* Update build_docker_images.yml

* Update build_docker_images.yml

* Update build_docker_images.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

@pacman100 pacman100 pacman100 approved these changes

@glegendre01 glegendre01 Awaiting requested review from glegendre01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@younesbelkada @HuggingFaceDocBuilderDev @BenjaminBossan @pacman100