Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose bias attribute on tuner layers #1530

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Expose bias attribute on tuner layers #1530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22f1fb5
Expose bias attribute on tuner layers
BenjaminBossan Mar 4, 2024
d142cce
Add test for weight and bias attributes
BenjaminBossan Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/peft/tuners/tuners_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,11 @@ def weight(self) -> torch.Tensor:
weight = base_layer.weight
return weight

@property
def bias(self) -> torch.Tensor:
base_layer = self.get_base_layer()
return base_layer.bias

def merge(self, safe_merge: bool = False, adapter_names: Optional[list[str]] = None) -> None:
raise NotImplementedError

Expand Down
7 changes: 7 additions & 0 deletions tests/test_custom_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,6 +805,13 @@ def test_delete_inactive_adapter(self, test_name, model_id, config_cls, config_k
def test_adding_multiple_adapters_with_bias_raises(self, test_name, model_id, config_cls, config_kwargs):
self._test_adding_multiple_adapters_with_bias_raises(model_id, config_cls, config_kwargs)

def test_weight_bias_attributes(self):
model = MLP()
config = LoraConfig(target_modules=["lin0"])
model = get_peft_model(model, config)
assert hasattr(model.base_model.model.lin0, "weight")
assert hasattr(model.base_model.model.lin0, "bias")

def test_existing_model_card(self):
# ensure that if there is already a model card, it is not overwritten
model = MLP()
Expand Down
Loading