Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Make adaptation prompt CI happy for transformers 4.39.0 #1551

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

younesbelkada
Copy link
Contributor

As per title!

huggingface/transformers#29492 being merged, seq_len is officially deprecated in transformers 4.39.0

cc @pacman100 @BenjaminBossan

Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @younesbelkada for the quick fix!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thanks for figuring this out quickly. I just have a nit with the comment, but otherwise LGTM.

Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
@younesbelkada younesbelkada merged commit a1fe368 into huggingface:main Mar 11, 2024
14 checks passed
@younesbelkada younesbelkada deleted the fix-transformers-main-2 branch March 11, 2024 11:53
BenjaminBossan added a commit to BenjaminBossan/peft that referenced this pull request Mar 14, 2024
…face#1551)

* fix for transformers 4.39.0

* Update src/peft/tuners/adaption_prompt/utils.py

Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>

---------

Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants