Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Minor issues in docs, re-raising exception #1581

Merged

Conversation

BenjaminBossan
Copy link
Member

A few unrelated things I noticed:

  • Typos in docs
  • Add mention that DoRA now supports Conv2d
  • Re-raise a caught exception (to not hide original error)

- Typos in docs
- Add mention that DoRA now supports Conv2d
- Re-raise a caught exception (to not hide original error)
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @BenjaminBossan!

Comment on lines +146 to +147
except Exception as exc:
raise ValueError(f"Can't find '{CONFIG_NAME}' at '{pretrained_model_name_or_path}'") from exc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐞

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

@sayakpaul sayakpaul merged commit 65b75a6 into huggingface:main Mar 22, 2024
14 checks passed
@BenjaminBossan BenjaminBossan deleted the fix-minor-issues-docs-and-error branch March 22, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants