print_trainable_parameters - format % to be sensible
#1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR replaces `trainable%: 0.5916145025956931` with `trainable%: 0.5916` as it's done already in `src/peft/mixed_model.py` probably `.2f` is more than enough, but since the other one uses `.4f` using that.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
BenjaminBossan
approved these changes
Apr 15, 2024
DTennant
pushed a commit
to DTennant/peft
that referenced
this pull request
Apr 19, 2024
This PR replaces `trainable%: 0.5916145025956931` with `trainable%: 0.5916` as it's done already in `src/peft/mixed_model.py`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
trainable%: 0.5916145025956931withtrainable%: 0.5916as it's done already insrc/peft/mixed_model.pyProbably
.2fis more than enough, but since the other one uses.4fusing that.